Closed
Conversation
Signed-off-by: Benjamin Fitch <benjamin.fitch@intel.com>
…structure for intel open-source rst projects Signed-off-by: Benjamin Fitch <benjamin.fitch@intel.com>
Signed-off-by: Benjamin Fitch <benjamin.fitch@intel.com>
Signed-off-by: Benjamin Fitch <benjamin.fitch@intel.com>
Signed-off-by: Benjamin Fitch <benjamin.fitch@intel.com>
Contributor
Contributor
Author
|
@mmeterel Sure. Worst case, I can replace the PR with a new one if the rebasing proves too unwieldy. |
andrewtbarker
approved these changes
Feb 9, 2022
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
Overall this looks fine to me. I agree with Mesut that we should maybe wait until the rocBLAS README is merged to merge this.
docs/build_setup.rst
Outdated
| =========== | ||
|
|
||
| #. | ||
| Install Intel(R) oneAPI DPC++ Compiler (select variant as per requirement). |
Contributor
There was a problem hiding this comment.
Should we link to selecting_a_compiler.rst here?
Signed-off-by: Benjamin Fitch <benjamin.fitch@intel.com>
Contributor
Author
|
Closing and submitting a new one that's up-to-date with the rocBLAS changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some "About" and "Get Started" content out of the readme into the documentation, add a link in the readme to the documentation, and perform copy editing on the affected content.